-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lago integration #4620
Merged
Merged
Lago integration #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauAraujo
force-pushed
the
lago-integration
branch
2 times, most recently
from
May 14, 2024 21:09
58b82b6
to
71c9483
Compare
jusrhee
approved these changes
May 15, 2024
Co-authored-by: Mauricio Araujo <[email protected]>
MauAraujo
force-pushed
the
lago-integration
branch
from
May 15, 2024 19:04
aa61aa8
to
99dfe64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POR-
What does this PR do?
This PR switches all the Metronome backend endpoints to use Lago, using their Go client. Since Lago allows us to specify an external id, we can stop storing the usage id in the database columns. Another major change is that since we are using the client, we can get rid of most of the Metronome types and the logic for calling the endpoint, which makes the code cleaner.